[SQLite] Fix invalid changeColumn regex causing deletions #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a pretty serious bug in the Phinx SQLiteAdapter that causes columns to be destroyed when you're removing the default value of `''` from a string column. See comment here: cakephp#1093 (comment) There are no tests in phinx that prove what I've changed hasn't broken anything, and I'm not about to start writing all the test cases to prove this works. Maybe I have indeed broken some weird implementation detail that this regex was intended to target... oh well.
|
Thanks, I can actually see how the previous regex was wrong and this one is safer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the SQLiteAdapter that causes columns to be destroyed when removing a default value of
''from a string column.See comment here: #1093 (comment)
Unfortunately, there are no existing tests for this specific functionality that prove what I've changed hasn't broken anything.