Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on extension launch #450

Closed
Sovhan opened this issue Sep 21, 2021 · 1 comment
Closed

Crash on extension launch #450

Sovhan opened this issue Sep 21, 2021 · 1 comment
Labels
bug Something isn't working robotframework-ls

Comments

@Sovhan
Copy link

Sovhan commented Sep 21, 2021

Describe the bug
When opening a robot file and hereby launching the robocorp.robotframework-lsp extension in VSCode, no support is provided for robot framework language because of a crash.

To Reproduce

  1. Open a .robot file with a test case depending on local libraries
  2. observe logs as such:
    lsp: 2021-09-21 12:00:28 UTC pid: 361525 - Thread-1 - INFO - robocorp_ls_core.remote_fs_observer_impl
    Remote FS observer stderr: File ".vscode/extensions/robocorp.robotframework-lsp-0.23.0/src/robotframework_ls/vendored/robocorp_ls_core/libs/fsnotify_lib/fsnotify/init.py", line 238, in
    lsp: 2021-09-21 12:00:28 UTC pid: 361525 - Thread-1 - INFO - robocorp_ls_core.remote_fs_observer_impl
    Remote FS observer stderr: not self.accepted_file_extensions or path_name.endswith(self.accepted_file_extensions)
    lsp: 2021-09-21 12:00:28 UTC pid: 361525 - Thread-1 - INFO - robocorp_ls_core.remote_fs_observer_impl
    Remote FS observer stderr: TypeError: endswith first arg must be str or a tuple of str, not list

and in said lambda, follow accepted_file_extensions member to see its content, which is () and does not seem to be modified?

Expected behavior
Load the extension without crashing with the same behaviour as precedent versions.

Versions:

  • OS: Linux pop-os 5.11.0-7633-generic base Ubuntu 20.04 GNU/Linux
  • Robot Framework Version: 4.1.1 (Python 3.8.10 on linux)
  • Robot Framework Language Server Version: 0.23
  • Client Version: VSCode 1.60.1

Logs
See: https://github.com/robocorp/robotframework-lsp/blob/master/robotframework-ls/docs/reporting_issues.md for details on how to collect the logs.
robot_logs.1.others.lsp.361710.api.log
robot_logs.2.lsp.368418.api.log
robot_logs.lint.lsp.361610.api.log
robot_logs.lsp.361525.log
robot_logs.remote_fs_observer.361565.log

@Sovhan Sovhan added bug Something isn't working robotframework-ls labels Sep 21, 2021
@fabioz fabioz closed this as completed in 56da85b Sep 21, 2021
@fabioz
Copy link
Collaborator

fabioz commented Sep 21, 2021

I'm sorry about that, I've just pushed a new update with a fix for that (0.23.1) as this was really a critical issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working robotframework-ls
Projects
None yet
Development

No branches or pull requests

2 participants