-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on extension launch #450
Labels
Comments
I'm sorry about that, I've just pushed a new update with a fix for that ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When opening a robot file and hereby launching the robocorp.robotframework-lsp extension in VSCode, no support is provided for robot framework language because of a crash.
To Reproduce
lsp: 2021-09-21 12:00:28 UTC pid: 361525 - Thread-1 - INFO - robocorp_ls_core.remote_fs_observer_impl
Remote FS observer stderr: File ".vscode/extensions/robocorp.robotframework-lsp-0.23.0/src/robotframework_ls/vendored/robocorp_ls_core/libs/fsnotify_lib/fsnotify/init.py", line 238, in
lsp: 2021-09-21 12:00:28 UTC pid: 361525 - Thread-1 - INFO - robocorp_ls_core.remote_fs_observer_impl
Remote FS observer stderr: not self.accepted_file_extensions or path_name.endswith(self.accepted_file_extensions)
lsp: 2021-09-21 12:00:28 UTC pid: 361525 - Thread-1 - INFO - robocorp_ls_core.remote_fs_observer_impl
Remote FS observer stderr: TypeError: endswith first arg must be str or a tuple of str, not list
and in said lambda, follow accepted_file_extensions member to see its content, which is () and does not seem to be modified?
Expected behavior
Load the extension without crashing with the same behaviour as precedent versions.
Versions:
Logs
See: https://github.com/robocorp/robotframework-lsp/blob/master/robotframework-ls/docs/reporting_issues.md for details on how to collect the logs.
robot_logs.1.others.lsp.361710.api.log
robot_logs.2.lsp.368418.api.log
robot_logs.lint.lsp.361610.api.log
robot_logs.lsp.361525.log
robot_logs.remote_fs_observer.361565.log
The text was updated successfully, but these errors were encountered: