-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detections] - enable from_mmdetection
to extract tracker_id
from MMDetection result
#1381
Comments
Hi @rolson24 I just managed to plug in your MASA code into my football demo. I'd never be able to do it without your help. As for MASA: not bad, but I was hoping for a slightly better result. Would that allow us to plug in all MMTracking models? d82e7a_5-masa-result-rainbow-optimized.mp4 |
I don't think so. It seems like MASA is built on the trackers in the MMDet library, which are set up slightly different than the trackers in MMTracking. The trackers in MMTracking seem to output dicts of numpy arrays, while the trackers in MMDet output objects called So maybe not worth trying to support it if its a dead library anyway. |
As for the MASA performance, I also noticed it was pretty bad at handling occlusion and creating new track IDs. I looked a bit into the code and it seems like the actual tracking is a very simple tracking algorithm with no motion modeling. I think MASA has some pretty good potential if motion modeling was added, and a more strict matching pipeline was incorporated. I think the real benefit of MASA is its ability to plug into foundational open world detectors, and doesn't hold up as well in specific applications. I might try to play around and see if I can integrate it with a better tracker like BoTSORT with MASA as the ReID model. |
Maybe we should wait on the MASA integration because the library isn't quite there yet, and the tracking output will probably change. If we wanted to integrate a strong tracking library that is still being maintained, I think BoxMOT could be a pretty good option. It supports some pretty good trackers and several ReID models and has a clean install process. I am also in the process of adding some new SOTA trackers to it. |
@rolson24 If we disregard MASA for the moment, do other trackers in MMTrack have a consistent output format? |
Yes. They output a dict containing The main issue with MMTracking is that it hasn't been updated since 2022, and so none of the dependancies are updated to work with any of the newer libraries. It seems like all of the trackers from MMTracking have now been merged into MMDetection, which uses the same output format as MASA, and MMDetection has least had a release this year, so the dependancies are much more recent. |
@rolson24 in that case, could we expand |
Ya it would be pretty easy. I can work on it right now. |
@rolson24 that's awesome! thanks a lot! 🙏🏻 |
from_mmdetection
to extract tracker_id
from MMDetection result
Hm... I'm becoming increasingly convinced that tracking is the domain we should explore. If a library like MMDetection does not have trackers that work well out of the box, we could do something useful here. |
I am open the lend a hand here if you plan to integrate |
Search before asking
Description
This is somewhat similar to #1308 in that it would be modifying
from_mmdetection()
to supportTrackDataSample
s. This would allow for easy integration with the MMTracking library, which has several trackers implemented in it, as well as integration with the Match and Segment Anything (MASA) model.Use case
No response
Additional
I imagine it could be pretty simple and would only require checking if the input object has the
pred_track_instances
attribute, and then it could simply add the tracks with their track ID's into aDetections
object.Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: