Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow helm diff failures #1600

Open
jkroepke opened this issue Nov 24, 2020 · 4 comments
Open

Allow helm diff failures #1600

jkroepke opened this issue Nov 24, 2020 · 4 comments

Comments

@jkroepke
Copy link

Follow up from: #1595 (comment)

If a Chart wants to install CRD and Resources, helm diff may fail.

As I know a common workaround in helmfile is to disable the validation (#1124 and. #1373).

But validation is always good and protect agist spell issues or wrong indents, disable it might be the last resort. On Vanilla helm (3.4.1), I didn't need to disable the validation.

In this case an option would be great to just allow failures from helm diff since most in the time the failures are non critical.

I know, I could suppress diff completely.

But I could I suppress diff only on installations? Or what about to disable validation only for helm diff but still enabled for the helm upgrade command?

Thanks

@mumoshu
Copy link
Collaborator

mumoshu commented Feb 3, 2021

@jkroepke Hey! In #1618, I've added disableValidationOnInstall which I believe is exactly the first option you proposed. Would you mind giving it a try?

@jkroepke
Copy link
Author

jkroepke commented Feb 4, 2021

--skip-diff-on-install from your pr looks more interest for me.

@mumoshu
Copy link
Collaborator

mumoshu commented Feb 4, 2021

@jkroepke Yeah- I usually recommend using command-line flags for operational concerns and use YAML config for anything else. So --skip-diff-on-install is definitely an option depending on your situation.

@DjinNO
Copy link

DjinNO commented Jan 6, 2023

It's can be also because of

experiments {
  manifest = true
 }

in Helm Terraform provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants