Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic: true by default? #512

Open
mumoshu opened this issue Mar 29, 2019 · 5 comments
Open

atomic: true by default? #512

mumoshu opened this issue Mar 29, 2019 · 5 comments

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Mar 29, 2019

Creating this dedicated issue for visibility. See #471 for more context.

@mumoshu
Copy link
Collaborator Author

mumoshu commented May 30, 2019

For backward-compatibility reason, this unlikely to happen in shorter term.

Instead, we'd better add helmfile sync --atomic that sets atomic: true to every release.

Or helmfile sync --atomic-by-default to set atomic: true only when the release explicitly set it to atomic: false for more granular control.

@mumoshu
Copy link
Collaborator Author

mumoshu commented May 30, 2019

Context: #256 (comment)

@mumoshu mumoshu mentioned this issue Jul 29, 2019
4 tasks
@bozaro
Copy link

bozaro commented Sep 26, 2019

I'm removed --atomic from my CI test environments deployments, because it's make too difficult diagnostics: I should redeploy manually and hope for bug reproduce.

Also I add extra logic to workaround Error: UPGRADE FAILED: "xxx" has no deployed releases, because upgrade --install --force don't solve this error with helm3.

@RobertoUa
Copy link

I would be super awesome if when I send SIGTERM (or cmd-c in terminal) during upgrade/install of a chart, it would revert it, instead of leaving it hanging out.

@Xtigyro
Copy link

Xtigyro commented Apr 13, 2020

Hey @bozaro - could you please shed some more light on what extra logic you've started using to work around the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants