add optional parameter source to Get Table Cell Value Keyword
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I finally have again time to look at other projects besides the core framework. Could you try to make a test for this? We try to include tests for all new features. |
|
Sure. Actually I wanted to discuss this solution with you first in context of the problem we are trying to solve. I will try to reach you on IRC channel. |
|
|
||
| private String getTextFromCellComponent(int row, int col) { | ||
| Component cellRendererComponent = getCellRendererComponent(row, col); | ||
| System.out.println(cellRendererComponent.getClass().getName()); |
There was a problem hiding this comment.
I dont mind adding debug logging, but some context should be provided "Getting text from element of type xxxx" and logged perhaps at debug level?
|
I have added tests and documentation. |
When source is set to "model", text extractor won't try to get text from cell's component firsts and will get it directly from table model. When source is set to "auto" (default) old strategy is used, i.e. extractor will first try to extract text from cell's component and then if this fails it will get it from table model.
WojtekKowaluk
added a commit
that referenced
this pull request
Jul 29, 2015
add optional parameter `source` to Get Table Cell Value Keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When source is set to "model", text extractor won't try to get text from cell's component firsts and will get it directly from table model. When source is set to "auto" (default) old strategy is used, i.e. extractor will first try to extract text from cell's component and then if this fails it will get it from table model.