Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary else blocks #269

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

lmpham1
Copy link

@lmpham1 lmpham1 commented Oct 11, 2021

Description

Removed unnecessary else blocks and replaced them with a simple return statement in 2 files: /NearBeach/private_media.py and /NearBeach/views/authentication_views.py

This fixes #268

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Database change that requires a migration
  • This change requires a documentation update

How Has This Been Tested?

  • Local manual testing via "./manage runserver"
  • Local Python Unit Testing via "./manage test"
  • Local Cypress E2E Testing
  • Tested on virtual box
  • Tested on server

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@robotichead robotichead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@robotichead robotichead merged commit b0d39ab into nearbeach:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(PYL-R1705) Unnecessary else / elif used after return
2 participants