Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need doc on frame conventions #38

Open
tridge opened this issue May 30, 2020 · 2 comments
Open

need doc on frame conventions #38

tridge opened this issue May 30, 2020 · 2 comments

Comments

@tridge
Copy link

tridge commented May 30, 2020

The docs really need a section on frame conventions. Here is what I've discovered:

  • robot.position is NWU in meters
  • robot.orientation is [q1, q2, q3, w]
  • robot.linear_velocity is NWU earth frame, in m/s
  • eulers are have roll +ve right, pitch +ve down, yaw +ve counter-clockwise from above (in radians)
  • robot.angular_velocity is in earth frame (this one is really non-obvious!). Needs to be rotated by multiplying by a rotation matrix for orientation to get to body frame for gyro equivalent. angular_velocity is +ve right for roll, +ve down for pitch, +ve counter-clockwise (from above) for yaw
  • acceleration seems to not be available (always gives zero) so needs to be calculated by differentiating velocity in earth frame, adding gravity and rotating to body frame
  • when world axes are shown, red is north, green is west, blue is up

I think it would be really nice to have to_earth_frame and to_body_frame helper functions

@lrozo
Copy link
Collaborator

lrozo commented Jun 8, 2020

Hi @tridge ,

We have this documentation thing as a pending task in our endless ToDo list. As every user may discover new issues, missing stuff, or develop new features, we really encourage people to contribute to Pyrobolearn. So, it would be really cool if you can contribute, for example, by providing some short documentation about the frame conventions you mentioned in this issue.

We would be glad to review this through a pull request!

Leonel

@tridge
Copy link
Author

tridge commented Jun 8, 2020

So, it would be really cool if you can contribute, for example, by providing some short documentation about the frame conventions you mentioned in this issue.

sure! I'll do a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants