Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the code that extracts a list of devices from a given simulation instance from gzyarp::Handler and pass it to BipedalLocomotion::RobotInterface::YarpRobotControl::setDriver() and BipedalLocomotion::RobotInterface::YarpSensorBridge::setDriversList #149

Open
traversaro opened this issue Apr 5, 2024 · 6 comments
Assignees

Comments

@traversaro
Copy link
Member

To do so, we can build on top of the test in #147 and add some similar tests that instead uses BipedalLocomotion::RobotInterface::YarpRobotControl and BipedalLocomotion::RobotInterface::YarpSensorBridge.

However, we can't add a dependency on blf here. So we need to understand if this code can go in blf, or in a third package that depends on both blf and gz-sim . In both cases, we need to install the headers corresponding to the gzyarp::Handler , so that downstream projects can use it.

@xela-95
Copy link
Member

xela-95 commented Apr 19, 2024

However, we can't add a dependency on blf here. So we need to understand if this code can go in blf, or in a third package that depends on both blf and gz-sim . In both cases, we need to install the headers corresponding to the gzyarp::Handler , so that downstream projects can use it.

Now that the blocking issue #150 has been closed, and with #147 almost finished, I'm starting to look at this issue. Where can I put the code? @traversaro

@traversaro
Copy link
Member Author

traversaro commented Apr 19, 2024

Actually I forgot to update the issue. We discussed about this with @GiulioRomualdi , and given that blf methods of interest takes (or can take) in input a PolyDriverList, probably we can just ad a function/method in the public interface of gz-sim-yarp-plugins, no need to have a new repo or add dependencies between blf and this repo

@xela-95
Copy link
Member

xela-95 commented Apr 26, 2024

Actually I forgot to update the issue. We discussed about this with @GiulioRomualdi , and given that blf methods of interest takes (or can take) in input a PolyDriverList, probably we can just ad a function/method in the public interface of gz-sim-yarp-plugins, no need to have a new repo or add dependencies between blf and this repo

@traversaro so if I understood it correctly, I should implement these methods in the public interface of gz-sim-yarp-plugins (with no additional dependency), but then I should have a separate project where I can call the new interface methods of gz-sim-yarp-plugins but also the BipedalLocomotion::RobotInterface::YarpRobotControl/BipedalLocomotion::RobotInterface::YarpSensorBridge ones?

@traversaro
Copy link
Member Author

Actually I forgot to update the issue. We discussed about this with @GiulioRomualdi , and given that blf methods of interest takes (or can take) in input a PolyDriverList, probably we can just ad a function/method in the public interface of gz-sim-yarp-plugins, no need to have a new repo or add dependencies between blf and this repo

@traversaro so if I understood it correctly, I should implement these methods in the public interface of gz-sim-yarp-plugins (with no additional dependency), but then I should have a separate project where I can call the new interface methods of gz-sim-yarp-plugins but also the BipedalLocomotion::RobotInterface::YarpRobotControl/BipedalLocomotion::RobotInterface::YarpSensorBridge ones?

Yes, I think that can be just an example on how to use BLF + gz-sim, the code will me quite limited so no need to have a dedicated project for it.

@xela-95
Copy link
Member

xela-95 commented May 3, 2024

I created a temporary repository to host the example at https://github.com/xela-95/blf-gz-sim-example

When it works I will put it into a more meaningful place, like an example folder of gz-sim-yarp-plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants