Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the minimum depth of the depthimage_to_{mono, rgb} portmonitors #2956

Open
xEnVrE opened this issue Mar 14, 2023 · 4 comments
Open

Comments

@xEnVrE
Copy link
Contributor

xEnVrE commented Mar 14, 2023

Is your feature request related to a problem? Please describe.
We started using a new RealSense, namely the short-range camera D405, which can provide good depth maps for object as near as 7 cm to the camera.

As we tipically do, it is always useful to visualize the depth map in a yarpview using the depthimage_to_rgb portmonitor for debugging or just to quickly check that the camera is working as expected.

Unfortunately, the depthimage_to_rgb portmonitor is ignoring any value of depth lower than 0.2 m:

Describe the solution you'd like
Would it be possible to lower that value to something smaller, e.g. 0.01 m?

I can open a PR in case.

Additional context

This is an example of the depth visualization using the current configuration, min = 0.2:

while this is the same scene after changing min to 0.01:

cc @randaz81

@xEnVrE
Copy link
Contributor Author

xEnVrE commented Mar 15, 2023

After talking with @Nicogene, we realized that the minimum is limited to 0.2 also for the depthimage_to_mono portmonitor:

@xEnVrE xEnVrE changed the title Decrease the minimum depth of the depthimage_to_rgb portmonitor Decrease the minimum depth of the depthimage_to_{mono, rgb} portmonitors Mar 15, 2023
@randaz81
Copy link
Member

I think the best way to proceed is to add a run-time parameter to allow users to choose max and min

@randaz81
Copy link
Member

Even if is a new feature, I think we can handle this as a bugfix. I'll thus proceed on the yarp 3.8 branch.

@randaz81 randaz81 added this to the YARP 3.9.0 milestone Aug 16, 2023
@randaz81 randaz81 self-assigned this Aug 16, 2023
@xEnVrE
Copy link
Contributor Author

xEnVrE commented Sep 22, 2023

cc @Arya07 @pestrstr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants