Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gradle-wrapper to latest version #217

Closed
robstoll opened this issue Oct 16, 2019 · 4 comments · Fixed by #220 or #331
Closed

update gradle-wrapper to latest version #217

robstoll opened this issue Oct 16, 2019 · 4 comments · Fixed by #220 or #331
Assignees

Comments

@robstoll
Copy link
Owner

Code related feature

  • update the gradle wrapper
  • rename the resulting gradlew back to gr/gr.bat

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime,
    we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@pr0t3us
Copy link
Contributor

pr0t3us commented Oct 16, 2019

I'll work on this

@robstoll
Copy link
Owner Author

@pr0t3us unfortunately,I had to revert your commit as it caused problems in intellij. Projects could no longer be imported properly. Do you fancy to give it another shot and try to fix the problem with importing? Following the failure reported by IDEA

Warning:<i><b>root project 'atrium': Unable to resolve additional project configuration.</b>
Details: org.gradle.api.artifacts.ResolveException: Could not resolve all dependencies for configuration ':atrium-core-robstoll-lib-js:compileOnly'.
Caused by: org.gradle.internal.component.AmbiguousVariantSelectionException: More than one variant of project :atrium-translations-en_GB-js matches the consumer attributes:
  - Configuration ':atrium-translations-en_GB-js:runtimeElements':
      - Unmatched attributes:
          - Found artifactType 'jar' but wasn't required.
          - Found org.gradle.category 'library' but wasn't required.
          - Found org.gradle.dependency.bundling 'external' but wasn't required.
          - Found org.gradle.jvm.version '8' but wasn't required.
          - Found org.gradle.libraryelements 'jar' but wasn't required.
          - Found org.gradle.usage 'kotlin-runtime' but wasn't required.
      - Compatible attributes:
          - Required org.jetbrains.kotlin.localToProject 'local to :atrium-core-robstoll-lib-js' and found compatible value 'public'.
          - Required org.jetbrains.kotlin.platform.type 'js' and found compatible value 'js'.
  - Configuration ':atrium-translations-en_GB-js:runtimeElements' variant classes:
      - Unmatched attributes:
          - Found artifactType 'java-classes-directory' but wasn't required.
          - Found org.gradle.category 'library' but wasn't required.
          - Found org.gradle.dependency.bundling 'external' but wasn't required.
          - Found org.gradle.jvm.version '8' but wasn't required.
          - Found org.gradle.libraryelements 'classes' but wasn't required.
          - Found org.gradle.usage 'kotlin-runtime' but wasn't required.
      - Compatible attributes:
          - Required org.jetbrains.kotlin.localToProject 'local to :atrium-core-robstoll-lib-js' and found compatible value 'public'.
          - Required org.jetbrains.kotlin.platform.type 'js' and found compatible value 'js'.
  - Configuration ':atrium-translations-en_GB-js:runtimeElements' variant resources:
      - Unmatched attributes:
          - Found artifactType 'java-resources-directory' but wasn't required.
          - Found org.gradle.category 'library' but wasn't required.
          - Found org.gradle.dependency.bundling 'external' but wasn't required.
          - Found org.gradle.jvm.version '8' but wasn't required.
          - Found org.gradle.libraryelements 'resources' but wasn't required.
          - Found org.gradle.usage 'java-runtime' but wasn't required.
      - Compatible attributes:
          - Required org.jetbrains.kotlin.localToProject 'local to :atrium-core-robstoll-lib-js' and found compatible value 'public'.
          - Required org.jetbrains.kotlin.platform.type 'js' and found compatible value 'js'.</i>

@robstoll robstoll reopened this Oct 19, 2019
@robstoll robstoll removed this from the 0.9.0 milestone Oct 19, 2019
@robstoll robstoll removed hacktoberfest good first issue Good for newcomers labels Nov 4, 2019
@piyushmor
Copy link
Contributor

Hi @robstoll , I can take this over. Also, Gradle 6.0 is out!

@robstoll
Copy link
Owner Author

robstoll commented Jan 8, 2020

@piyushmor un-assigning you so that others can take over, as you don't seem to work on it any more. Let me know in case you want to take it up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment