Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailSender: findings_header, investigate link and source should be optional #1454

Open
tabea-kinexon opened this issue Jun 13, 2024 · 5 comments

Comments

@tabea-kinexon
Copy link

Is your feature request related to a problem?

Yes. I need to have full control over the email content that is being sent.
e.g.: The emails might go to people that do not have access to the Robusta platform. So sending emails with that link will be more confusing than helpful.

Describe the solution you'd like

Add a config parameter to the emailSink (e.g. robustaFindingsEnrichment). Default can be true, however, if set to false only content added by enrichers/actions is added to the email.

Describe alternatives you've considered
Remove the custom blocks from the send_finding method in the MailSender and offer it as an enrichment

Copy link

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

  • 💬 Slack Community: Join Robusta team and other contributors on Slack here.
  • 📖 Docs: Find our documentation here.
  • 🎥 YouTube Channel: Watch our videos here.

@tabea-kinexon tabea-kinexon changed the title MailSender: findings_header, investigate link and source shoudl be optional MailSender: findings_header, investigate link and source should be optional Jun 13, 2024
@aantn
Copy link
Collaborator

aantn commented Jun 15, 2024

Hey, thanks for opening an issue. I had a question about your use case, as we've started to roll out RBAC on the SaaS platform on our paid plans. Does RBAC mitigate the need for this in any way?

We're happy to accept a PR for not sending the platform links of course, but if we could solve this by giving those people limited access, maybe that is a better outcome.

@tabea-kinexon
Copy link
Author

Hey,

unfortunately I do not want the people I send this emails to, to have access to it at all.
I will see if I find time to code a solution and create a PR this month.

@aantn
Copy link
Collaborator

aantn commented Jun 19, 2024

Sounds good. Is there any content that those people should see? Curious to learn more on the motivation for limiting it, as it may help us improve the product.

@RobertSzefler
Copy link
Contributor

#1491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants