-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Craft 5.3 #45
Comments
Thanks, will have to look into this. For now, I have released 3.0.1 which has a constraint on Craft CMS < 5.3. |
The issue occurs because the default value of a BaseRelationField has changed: https://github.com/craftcms/cms/pull/15400/files#diff-dd150284a0df94daa2918aaacda81e6ad9b20bac8d429414043f37120a5769ddR100-R103 Since the default value for a BaseRelationField is no longer
Edit: You can fix the ReverseEntries field itself by overriding dbType: https://github.com/Marcuzz/craft-reverserelations/blob/develop/src/fields/ReverseEntries.php#L40-L43 This works if you have a read only field from the ReverseEntries field side, but editing from that side still requires a fix in the code that saves relations. |
An update to my previous comment ☝️ These changes fixes all the aforementioned issues, and makes it compatible with 5.3: develop...Marcuzz:craft-reverserelations:develop Let me know if you would like me to submit a PR 😄 |
Thanks, will look into it the coming days. No PR needed. |
3.0.2 is out now with this fix, thanks a lot @Marcuzz ! |
The changes in Craft 5.3 that made relation fields multi-instance (craftcms/cms#15400) break the functionality of this plugin.
The immediate problem is that the
is_array($value)
check innormalizeValue
always returnstrue
now, skipping the plugin logic. But there are probably other implications.The text was updated successfully, but these errors were encountered: