Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require review from other code owner #12

Open
4 tasks
Anton-4 opened this issue Jul 13, 2021 · 4 comments
Open
4 tasks

Require review from other code owner #12

Anton-4 opened this issue Jul 13, 2021 · 4 comments

Comments

@Anton-4
Copy link

Anton-4 commented Jul 13, 2021

The way to go seems to be to:

  • set up CODEOWNERS
  • require one review for the trunk branch
  • require reviews from CODEOWNERS

The CODEOWNERS file should be set up to have at least two trusted contributors as code owners per folder.
That way every PR will be reviewed by a (different) trusted contributor.

  • Verify settings by trying to merge PR with review from someone who is not a code owner.
@BrianHicks
Copy link
Member

I'd like to set up a group like @roc-lang/rbt-reviewers for this. @rtfeldman what do you think? Based on activity so far, it'd maybe be you, me, and @bhansconnect?

@BrianHicks
Copy link
Member

ping @rtfeldman! I'm about to open another PR assigning basically this group. Would it make sense or shall we skip it?

@rtfeldman
Copy link
Contributor

rbt-reviewers sounds good! 👍

@BrianHicks
Copy link
Member

Would you mind creating that group? I can set CODEOWNERS up afterwards but I am not a member of the roc-lang org with sufficient permissions to make a group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants