Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate that we aren't getting hash collisions #81

Open
BrianHicks opened this issue Oct 19, 2022 · 0 comments
Open

validate that we aren't getting hash collisions #81

BrianHicks opened this issue Oct 19, 2022 · 0 comments
Labels
Milestone

Comments

@BrianHicks
Copy link
Member

BrianHicks commented Oct 19, 2022

When rbt gets a Job from Roc, it uses the information to create a key, which is then used as the identifier for the job in the build graph. However unlikely it is, it's possible that we could get a collision there.

To guard against this, rbt could keep a mapping of key to job while constructing the build graph. Every time we got a new job, we'd insert into this mapping. If we already had an item in there, we'd verify that the new value was exactly equal to the existing one. If it wasn't, we'd raise an error and ask the caller to set some field designed to avoid hash collisions.

Thanks, @bhansconnect, for the idea of how to mitigate this!

@BrianHicks BrianHicks added this to rbt Oct 19, 2022
@BrianHicks BrianHicks moved this to Todo in rbt Nov 14, 2022
@BrianHicks BrianHicks added this to the initial build milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant