Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use StackFallbackAllocator in zig bytecode gen #1156

Open
folkertdev opened this issue Apr 5, 2021 · 0 comments
Open

use StackFallbackAllocator in zig bytecode gen #1156

folkertdev opened this issue Apr 5, 2021 · 0 comments
Labels
builtins Relates to roc builtins like Bool, List, Str ... perf-emitted The performance of emitted Roc code, as opposed to the compiler itself.
Milestone
zig 8.0.0

Comments

@folkertdev
Copy link
Contributor

In the various walk functions, we reserve space for the accumulator. Currently that space is allocated on the heap, but with a StackFallbackAllocator we could automatically allocate small accumulator values on the stack (and most accumulator values will be small). Sadly, this allocator is broken in zig 0.7.1, but there has been a fix ziglang/zig#7425 that will be in 8.0.0.

I tried copying the fixed implementation into our project, but could not get that to work (see 858f19f)
@folkertdev folkertdev added this to the zig 8.0.0 milestone Apr 5, 2021
@skyqrose skyqrose added perf-emitted The performance of emitted Roc code, as opposed to the compiler itself. builtins Relates to roc builtins like Bool, List, Str ... labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builtins Relates to roc builtins like Bool, List, Str ... perf-emitted The performance of emitted Roc code, as opposed to the compiler itself.
Projects
None yet
Milestone
zig 8.0.0
Development

No branches or pull requests
2 participants
@folkertdev @skyqrose