Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crti.o, crtn.o, and Scrt1.o should not use absolute paths #574

Closed
bhansconnect opened this issue Oct 8, 2020 · 2 comments · Fixed by #580
Closed

crti.o, crtn.o, and Scrt1.o should not use absolute paths #574

bhansconnect opened this issue Oct 8, 2020 · 2 comments · Fixed by #580
Labels
bug Something isn't working

Comments

@bhansconnect
Copy link
Contributor

The paths used here are absolute, which makes them not work on all linux distrobutions. For example, on Arch linux, the paths do not contain x86_64-linux-gnu and are just /usr/lib/*.o. We need a way to correctly pull in these paths for linking.
@bhansconnect bhansconnect added the bug Something isn't working label Oct 8, 2020
@rtfeldman
Copy link
Contributor

Fun, looks like it's different on different machines and only gcc knows where it lives 😂

At least gcc is willing to divulge its secrets: pantsbuild/pants#5943 (comment)

@rtfeldman
Copy link
Contributor

@andrewrk is this something Zig delegates to clang, or is there a better way to find the paths for these?

@bhansconnect bhansconnect mentioned this issue Oct 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make link paths generic and add libgcc_s roc-lang/roc
2 participants
@rtfeldman @bhansconnect