Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roc_sender should quiesce UDP traffic when not playing audio #4

Open
twojstaryzdomu opened this issue Jul 1, 2021 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@twojstaryzdomu
Copy link

Currently, the roc_sender module is sending heavy UDP traffic whether the client is playing audio or not. It can impact the performance of the network when not playing anything and/or lead to unnecessary charges. That traffic is seen as redundant in the network, seeing as it does not lead to anything being played. Unless the sender module is unloaded manually, there is no way to stop the traffic. The redundant traffic precludes the use of roc over metered connections without prior access to the Pulseaudio load-module/unload-module commands, which is greatly impractical.
Ideally, the sender should stop sending any data to the client as soon as playback is stopped.

@gavv
Copy link
Member

gavv commented Jul 1, 2021

Totally agree. This is a known problem though: #22

@gavv gavv transferred this issue from roc-streaming/roc-toolkit Nov 28, 2022
@gavv gavv added the duplicate Already addressed by another issue or pull request label Nov 28, 2022
@gavv gavv closed this as completed Nov 28, 2022
@gavv gavv removed the duplicate Already addressed by another issue or pull request label Nov 28, 2022
@gavv gavv reopened this Nov 28, 2022
@gavv gavv changed the title Pulseaudio roc_sender quiesce UDP traffic when not playing audio Pulseaudio roc_sender should quiesce UDP traffic when not playing audio Nov 29, 2022
@gavv
Copy link
Member

gavv commented Nov 29, 2022

To achieve this, roc_sender sink should handle suspend request from PulseAudio and stop sender. Accordingly, it should handle resume request from PulseAudio and restart sender.

@gavv gavv changed the title Pulseaudio roc_sender should quiesce UDP traffic when not playing audio roc_sender should quiesce UDP traffic when not playing audio Nov 29, 2022
@gavv gavv added the enhancement New feature or request label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants