Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't rock-bundle-find omit the full path if possible, even if it is not passed as relative path? #39

Open
moooeeeep opened this issue May 23, 2022 · 0 comments

Comments

@moooeeeep
Copy link

I just noticed that rock-bundle-sel gives different output when given a relative path to the bundle vs when given just the name:

devel@rock-docker:/opt/workspace$ echo $ROCK_BUNDLE_PATH
/opt/workspace/bundles
devel@rock-docker:/opt/workspace$ rock-bundle-find bundle_name
[DEPRECATED] utilrb/hash/slice is deprecated, [...]
/opt/workspace/bundles/bundle_name
devel@rock-docker:/opt/workspace$ rock-bundle-find bundles/bundle_name
[DEPRECATED] utilrb/hash/slice is deprecated, [...]
bundle_name

This seems strange to me. IMO If it can find the bundle via the name, and it is located at the ROCK_BUNDLE_PATH, it should also return just the name and not the path.

I think the script should check if the bundle is registered here too and adjust the output accordingly. Or can we ditch the registered-check there altogether because only registered bundles are iterated in the first place? Quiet output doesn't seem to make sense there, does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant