Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge MC20 support ? #4

Open
doudou opened this issue Apr 3, 2018 · 6 comments
Open

Merge MC20 support ? #4

doudou opened this issue Apr 3, 2018 · 6 comments

Comments

@doudou
Copy link
Member

doudou commented Apr 3, 2018

When I created the common_models bundle, I did so using BIR's rock bundle, which contained the MC20 task.

Right now, we end up having to remove said task. The alternative would be to merge @saarnold's MC20 support (https://github.com/saarnold/drivers-controldev/tree/mc20support). Would there be a downside to that ?

Obviously, the comparable support would have to be merged on the orogen component (from this branch)

@saarnold @g-arjones

@g-arjones
Copy link

Sounds good...

@saarnold
Copy link
Member

saarnold commented Apr 3, 2018

The reason why it wasn't merged to master is because @goldhoorn was suggesting to design the component in a more generic way. See #1
However if we don't have anyone willing to do it I'm good with merging it to master.
In the PR we should also cleanup the code a bit.

@saarnold
Copy link
Member

saarnold commented Apr 3, 2018

@Nikpec offered to prepare a PR by next week.

@doudou
Copy link
Member Author

doudou commented Apr 24, 2018

Ping @Nikpec @saarnold

@Nikpec
Copy link

Nikpec commented May 9, 2018

I'm sorry. I forgot this. I'll do it on Monday at the latest.

@doudou
Copy link
Member Author

doudou commented Jan 31, 2019

Re-ping ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants