Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep delete doesn't work as expected #27

Open
xibre opened this issue Feb 26, 2018 · 0 comments
Open

Deep delete doesn't work as expected #27

xibre opened this issue Feb 26, 2018 · 0 comments

Comments

@xibre
Copy link

xibre commented Feb 26, 2018

@rocknrolla777 Hello. First of all, thanks for this awesome mixin.

I tried to set the options as described in the readme, but I have some problems when setting the deepDelete: true in the mixin options. This option is simply ignored and it leads to the skipping of the related model deep deletion (when debug mode is enabled, I can see the "Skipping delete for MyModelName" message printed).

I think this problem is caused by this line. I guess it should instead be:

...
if (relationDeepDelete || options.deepDelete) {
  ...

For now to make deep delete work, I had to set deepDelete: true for all the relations exclusively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant