Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

feat: use dynamic component to define container element #229

Merged
merged 5 commits into from
Jun 5, 2022

Conversation

shemsiu
Copy link
Contributor

@shemsiu shemsiu commented Jun 3, 2022

No description provided.

@netlify
Copy link

netlify bot commented Jun 3, 2022

👷 Deploy request for vue-virtual-scroll-grid accepted.

Name Link
🔨 Latest commit f808cd0
🔍 Latest deploy log https://app.netlify.com/sites/vue-virtual-scroll-grid/deploys/629c60921ad07d000810071b

Copy link
Owner

@rocwang rocwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The code looks good to me.
Could you document the newly added props probeTag and tag in README.md?

@shemsiu
Copy link
Contributor Author

shemsiu commented Jun 5, 2022

Thanks for the PR! The code looks good to me. Could you document the newly added props probeTag and tag in README.md?

Updated :)

@rocwang rocwang self-requested a review June 5, 2022 22:49
@rocwang rocwang changed the title use dynamic component to define container element feat: use dynamic component to define container element Jun 5, 2022
@rocwang rocwang merged commit d2e9875 into rocwang:main Jun 5, 2022
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants