Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomNavigationBarItem needs to be updated #10

Open
Zazo032 opened this issue Sep 1, 2020 · 2 comments · May be fixed by #12
Open

BottomNavigationBarItem needs to be updated #10

Zazo032 opened this issue Sep 1, 2020 · 2 comments · May be fixed by #12

Comments

@Zazo032
Copy link

Zazo032 commented Sep 1, 2020

BottomNavigationBarItem's title property was deprecated after Flutter 1.19.0:

'title' is deprecated and shouldn't be used. Use "label" instead, as it allows for an improved text-scaling experience. This feature was deprecated after v1.19.0.

However, if using label, the plugin throws an error:

════════ Exception caught by widgets library ═══════════════════════════════════════════════════════
The following assertion was thrown building LayoutBuilder:
'package:flutter/src/widgets/text.dart': Failed assertion: line 56 pos 15: 'child != null': is not true.

The relevant error-causing widget was: 
  LayoutBuilder file:///C:/Users/crist/AppData/Local/Pub/Cache/hosted/pub.dartlang.org/navigation_rail-1.5.0/lib/navigation_rail.dart:56:14
When the exception was thrown, this was the stack: 
#2      new DefaultTextStyle (package:flutter/src/widgets/text.dart:56:15)
#3      NavRail._buildTab (package:navigation_rail/navigation_rail.dart:224:17)
#4      NavRail.build.<anonymous closure> (package:navigation_rail/navigation_rail.dart:136:27)
#5      _LayoutBuilderElement._layout.<anonymous closure> (package:flutter/src/widgets/layout_builder.dart:124:33)
#6      BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2626:19)
...
════════════════════════════════════════════════════════════════════════════════════════════════════
@rodion-m
Copy link

Fix: #11

@rodydavis
Copy link
Owner

Awesome!

@techno-disaster techno-disaster linked a pull request May 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants