Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wsProtocols should take string|string[] #47

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix: wsProtocols should take string|string[] #47

merged 1 commit into from
Aug 1, 2023

Conversation

roerohan
Copy link
Owner

@roerohan roerohan commented Aug 1, 2023

Description

Change the type of wsProtocols from string to string | string[].

Resolved issues

Closes #45

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@roerohan roerohan merged commit 4235cce into roerohan:main Aug 1, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
## [0.5.14](v0.5.13...v0.5.14) (2023-08-01)

### Bug Fixes

* wsProtocols should take string|string[] ([#47](#47)) ([4235cce](4235cce))

skip-checks: true
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🎉 This PR is included in version 0.5.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass multiple protocols in rfbOptions.wsProtocols
2 participants