react-scripts dependency breaks newer vite/ts projects

[jaredzwick]

Are you certain it's a bug?

• Yes, it looks like a bug

Are you sure this is not an issue in noVNC?

• It is not a noVNC issue

Is there an existing issue for this?

• I have searched existing issues, it hasn't been reported yet

Issue description

Please add react-scripts to dev dependencies instead of normal dependencies

[aorsmen]

If you try to use typescript v5.x, this issue still persists even if you put react-scripts in dev dependencies.

npm ERR! While resolving: react-scripts@5.0.1
npm ERR! Found: typescript@5.6.3
npm ERR! node_modules/typescript
npm ERR! dev typescript@"5.6.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional typescript@"^3.2.1 || ^4" from react-scripts@5.0.1
npm ERR! node_modules/react-scripts
npm ERR! dev react-scripts@"5.0.1" from the root project
npm ERR! peer react-scripts@">=5.0.0" from react-vnc@2.0.2
npm ERR! node_modules/react-vnc
npm ERR! react-vnc@"2.0.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: typescript@4.9.5
npm ERR! node_modules/typescript
npm ERR! peerOptional typescript@"^3.2.1 || ^4" from react-scripts@5.0.1
npm ERR! node_modules/react-scripts
npm ERR! dev react-scripts@"5.0.1" from the root project
npm ERR! peer react-scripts@">=5.0.0" from react-vnc@2.0.2
npm ERR! node_modules/react-vnc
npm ERR! react-vnc@"2.0.2" from the root project