Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URIParser integration back in #18

Closed
davidanthoff opened this issue Feb 12, 2018 · 1 comment
Closed

Add URIParser integration back in #18

davidanthoff opened this issue Feb 12, 2018 · 1 comment

Comments

@davidanthoff
Copy link
Contributor

Would you be open to put the URIParser integration back in? It seems a really lightweight dependency, and my main use case for FilePaths is actually a really smooth conversion between file paths and URIs, so it would be great if we could just support that out of the box.

I'd be happy to do the PR that adds it back in.

@rofinn
Copy link
Owner

rofinn commented Feb 12, 2018

My reasoning for dropping it is:

  1. I'd like to see FilePaths.jl in the stdlib once we've flushed out all the details, so I wanted to avoid dependencies on other packages.
  2. I think that functionality makes more sense in URIParser as an optional dependency. Unfortunately, we don't seem to have a performant way of handling optional dependencies [1].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants