Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static and dynamic plugins for old flexbox are not equivalent #153

Closed
necolas opened this issue Feb 25, 2018 · 7 comments
Closed

Static and dynamic plugins for old flexbox are not equivalent #153

necolas opened this issue Feb 25, 2018 · 7 comments

Comments

@necolas
Copy link

necolas commented Feb 25, 2018

The static plugin for old flexbox is missing some of the features of the dynamic plugin, which means it doesn't provide the same browser compatibility

@robinweser
Copy link
Owner

Do you have detailed information, which parts are missing?
The default static prefixer is configured to support IE >= 11, so e.g. die IE flexbox fixes are not included in the default static version. The dynamic prefixer on the other hand checks the browser version via user-agent, so it might still add the IE stuff if an IE < 11 is provided.

You can also create your own static version with a different browser version range (see the docs).
If apart from that, inconsistence still exists, I am more than happy to fix it :P

@necolas
Copy link
Author

necolas commented Mar 2, 2018

@lyahdav patched the missing flexGrow in the plugin in this branch https://github.com/lyahdav/inline-style-prefixer/commits/3.0.8-flexbox-old-fixes. Comparing the plugins suggests there may be some other differences in the old flexbox compatibility offered

@lyahdav
Copy link

lyahdav commented Mar 3, 2018

Yup, the change I made in my fork was needed to support Android < 4.4 browser. Also I had to use the dynamic prefixer instead of static because of other things that are missing from the static prefixer flexboxOld plugin.

@robinweser
Copy link
Owner

Can anybody elaborate on missing differences that should be added as well? Going to release some fixes soon and want to add those!

@lyahdav
Copy link

lyahdav commented May 9, 2018

Take a look at this branch on my fork: https://github.com/lyahdav/inline-style-prefixer/commits/3.0.8-flexbox-old-fixes

Also compare the flexboxOld plugin under static vs dynamic folders in your main repo.

@robinweser
Copy link
Owner

Alright, I just added those changes as well. Next time, I'd appreciate a PR to add that directly 🙈

robinweser pushed a commit that referenced this issue May 9, 2018
@robinweser
Copy link
Owner

Just released 4.0.2 including those changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants