Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sane default for golanglint-ci #48

Open
haani-niyaz opened this issue Jul 10, 2022 · 1 comment
Open

Sane default for golanglint-ci #48

haani-niyaz opened this issue Jul 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@haani-niyaz
Copy link
Collaborator

haani-niyaz commented Jul 10, 2022

As per https://golangci-lint.run/usage/quick-start/ golanglint-ci enables a limited set of defaults. The disabled list contains some useful linters that perhaps should be enabled as it provides greater linting coverage. IMO some examples:

These could still be perceived as subjective so some consideration must be given to what is objectively useful. It is also best to consider adding these at the start of the project rather than midway as a custom/disparate styles may have proliferated through the code base and fixing the linting issues become cumbersome.

Acceptance Criteria

  • Assess linters that would be highly beneficial
  • Options to disable certain rules should exist (if deemed not applicable)
  • Add .golangci.yml file with enabled linters
  • Update docs
@haani-niyaz haani-niyaz added the enhancement New feature or request label Jul 10, 2022
@pallasite99
Copy link
Member

@haani-niyaz Maybe this can help ... keeping it here for reference:
#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants