Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only build the master branch on push #118

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Jan 18, 2021

Otherwise, in the case a PR is created from a branch that is pushed to
this repo, we create a workflow run for the PR and the branch itself.

Otherwise, in the case a PR is created from a branch that is pushed to
this repo, we create a workflow run for the PR and the branch itself.

Also switch to a fail-fast false strategy (because this is more helpful
when testing multiple Go versions in a matrix)
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I tend to avoid this by just opening PRs from forks :) but this seems like an okay fix too.

.github/workflows/test.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants