Calling callback in the useEffect itself is wrong #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

SalehDehqanpour opened this issue Sep 22, 2024 · 0 comments

SalehDehqanpour commented Sep 22, 2024

implement-react-hooks/hooks.js

Line 54 in be021ac

    
           if (hasChanged) cb();   // if dependencies has changed call the callback function.

According to react, the effect is run after the render and commit finishes but this code is calling cb in the body of useEffect itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment