gemspec required Rails 4 - can we drop Rails 3.2 support?

[olleolleolle]

There is a patch in https://github.com/roidrage/lograge/blob/master/lib/lograge/rails_ext/rack/logger.rb which seems to be about Rails 3.

Can this go away? Can it ever be needed, now that the gemspec has:

  s.add_runtime_dependency 'activesupport', '>= 4'
  s.add_runtime_dependency 'actionpack',    '>= 4'
  s.add_runtime_dependency 'railties',      '>= 4'

[bquorning]

I think only the comment is about Rails 3. Even in Rails 6.1, the Rails::Rack::Logger middleware is adding lines line Started GET "/session/new" for 127.0.0.1 at 2012-09-26 14:51:42 -0700 to the log.

That isn‘t to say that the patch couldn’t be implemented in other ways. For Rails 6.1 (and possibly earlier – I haven’t checked) it seems it would be enough to patch the #logger method to return a Null object responding to #info. (The current patch doesn’t even emit the "request.action_dispatch" event…)

[olleolleolle]

Ah, thanks for the deeper insight!

[olleolleolle]

#327