Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write-through caching in VFS #293

Open
LPGhatguy opened this issue Feb 19, 2020 · 2 comments
Open

Write-through caching in VFS #293

LPGhatguy opened this issue Feb 19, 2020 · 2 comments
Labels
scope: cli Relevant to the Rojo CLI two-way-sync This will help further two-way-sync.

Comments

@LPGhatguy
Copy link
Contributor

LPGhatguy commented Feb 19, 2020

Rojo's "strategy" for two-way sync caching is currently write-around. This means we can't distinguish changes that come from Rojo editing files and changes from other processes.

If we write-through instead, we can ignore filesystem changes that occur from ourselves because the read-back file contents will be the same.

@LPGhatguy LPGhatguy added scope: cli Relevant to the Rojo CLI two-way-sync This will help further two-way-sync. labels Feb 19, 2020
@LPGhatguy
Copy link
Contributor Author

Taking a try at this by breaking away the VFS implementation into a separate crate in the vfs-crate branch.

@Boegie19
Copy link
Contributor

Boegie19 commented Aug 9, 2022

I will take a shot at this as soon as #616 gets accepted or denied since else I will create a merge conflict as soon as it gets accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: cli Relevant to the Rojo CLI two-way-sync This will help further two-way-sync.
Projects
None yet
Development

No branches or pull requests

2 participants