Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rojo does not properly set an exit code if an error occurs #319

Closed
NobleDraconian opened this issue May 11, 2020 · 1 comment
Closed

Rojo does not properly set an exit code if an error occurs #319

NobleDraconian opened this issue May 11, 2020 · 1 comment
Labels
regression This bug wasn't a bug in a previous version of Rojo type: bug Something happens that shouldn't happen

Comments

@NobleDraconian
Copy link

NobleDraconian commented May 11, 2020

Currently in rojo 6.0.0-rc.1, rojo does not throw an exit code above 0 (e.g. exit code 1) if an error occurs while running a command. For example, if a non-existent file is specified in *.project.json and rojo build is ran, rojo will throw a 'file not found' error, but the exit code is not set above 0:

PS > rojo build -o CurrentBuild.rbxlx testenv.project.json
[ERROR] failed to query metadata of file `<PathToRepo>\./src/Server/Utilss`
[ERROR]   caused by The system cannot find the file specified. (os error 2)
PS > Write-Output $LASTEXITCODE
0

This makes it impossible for windows powershell/batch scripts to run conditional logic if a rojo build fails.

@LPGhatguy LPGhatguy added regression This bug wasn't a bug in a previous version of Rojo type: bug Something happens that shouldn't happen labels May 11, 2020
@LPGhatguy LPGhatguy added this to the Rojo 6 Blockers milestone May 11, 2020
@LPGhatguy
Copy link
Contributor

Hello!

I was not able to reproduce this issue. I believe you also use Foreman, which had a bug that was recently fixed for propagating error codes (Roblox/foreman#20).

As such, I'm going to close this issue. If you have a repro for this with either 6.0.0-rc.1 or the master branch without Foreman, feel free to re-open this issue! If it only occurs with Foreman, definitely open an issue over there.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression This bug wasn't a bug in a previous version of Rojo type: bug Something happens that shouldn't happen
Projects
None yet
Development

No branches or pull requests

2 participants