Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing correct address on serve on the CLI #555

Closed
WatermelonArray opened this issue Jun 13, 2022 · 1 comment
Closed

Not showing correct address on serve on the CLI #555

WatermelonArray opened this issue Jun 13, 2022 · 1 comment
Labels
scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen

Comments

@WatermelonArray
Copy link
Contributor

WatermelonArray commented Jun 13, 2022

I have been using Rojo for a network configuration. Using rojo serve, I can specify an address for Rojo to host to. In my case, my local machine's IPv4 address instead of hosting it on localhost.

However when successfully hosting to your specified address, the CLI displays incorrect information about where the host is sending data to - it still shows: Visit http://localhost:34872 in your browser for more information

This is does not effect my workflow at all but still is a minor bug.

Here is an image of the bug using Linux CLI binary Version 7.1.1:
2022-06-13-123125_1920x1080_scrot

This should display:
Visit http://192.168.1.226:34872 in your browser for more information


NOTE:
The port number changes when you specify a port value on the command, but not the address.
2022-06-13-125831_1920x1080_scrot

EDIT: Because you are hosting to an address, it is not hosting to localhost. If you try to connect to localhost:348721, you simply are unable to establish a connection.

@LPGhatguy LPGhatguy added type: bug Something happens that shouldn't happen scope: cli Relevant to the Rojo CLI labels Jun 13, 2022
@LPGhatguy
Copy link
Contributor

Thank you for the bug report, this is a great catch!

This should be a straightforward fix in cli/serve.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen
Projects
None yet
Development

No branches or pull requests

2 participants