Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rojo fails to sync serialized packages from remodel - "Unsupported property type: PackageLink.PackageId is of type Content" #557

Closed
schmatz opened this issue Jun 20, 2022 · 0 comments · Fixed by #558
Labels
type: bug Something happens that shouldn't happen

Comments

@schmatz
Copy link
Contributor

schmatz commented Jun 20, 2022

tl;dr I think we can fix this issue by updating rbx_binary from 0.6.4 to 0.6.5.

The problem

I noticed that when saving a package in a Place using remodel, it saves fine but when building the place with rojo, it runs into an error:

[ERROR rojo] Unsupported property type: PackageLink.PackageId is of type Content

rbx_binary fixed this back in April

FilamentGames fixed this back in April for rbx_binary with this PR. That was pulled into remodel by a commit updating remodel dependencies on June 13th in v0.10.0. Remodel now doesn't have this problem.

Rojo still has the problem due to old dependencies

However, rojo still has this problem. While #548 updated the contents of rbx_dom_weak from 2.3.0 to 2.4.0 on June 5th, rbx_binary still is on version 0.6.4, having last been updated on October 11th 2021. I believe it's likely that updating rbx_binary to 0.6.5 will fix this by pulling in the fix PR.

Updating the dependency seems to fix the problem.

On a local development copy, updating the rbx_binary dependency of Rojo to 0.6.5 seems to fix the problem (or at least the error message doesn't show up). I can't get some of the tests running locally though on the base due to timeouts. I think this might just be a problem with my local setup though.

I'm going to further verify the fixes locally. I can submit a PR, otherwise feel free to just bump the version.

@LPGhatguy LPGhatguy added the type: bug Something happens that shouldn't happen label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something happens that shouldn't happen
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants