Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rojo doesn't terminate on interrupts like Ctrl-C #629

Closed
mstarostik opened this issue Aug 20, 2022 · 1 comment
Closed

rojo doesn't terminate on interrupts like Ctrl-C #629

mstarostik opened this issue Aug 20, 2022 · 1 comment

Comments

@mstarostik
Copy link

Rojo 7.2.1 installed via foreman on Linux.

When hitting Ctrl-C (also tried Ctrl-\ FWIW), the rojo serve foreground process is terminated as expected. ~/.foreman/tools/rojo-rbx__rojo-7.2.1 serve however keeps running and prevents another launch on the same port.
Killing that one frees up the port of course.

Rojo should fully terminate on Ctrl-C instead.

$ rojo serve
Rojo server listening:
  Address: localhost
  Port:    34872

Visit http://localhost:34872/ in your browser for more information.
^C
$ rojo serve
Rojo server listening:
  Address: localhost
  Port:    34872

Visit http://localhost:34872/ in your browser for more information.
[ERROR rojo] Rojo crashed!
[ERROR rojo] This is probably a Rojo bug.
[ERROR rojo] 
[ERROR rojo] Please consider filing an issue: https://github.com/rojo-rbx/rojo/issues
[ERROR rojo] 
[ERROR rojo] Details: error binding to 127.0.0.1:34872: error creating server listener: Address already in use (os error 98)
[ERROR rojo] in file /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.14.19/src/server/server.rs on line 77
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
$ killall rojo-rbx__rojo-7.2.1
$ rojo serve
Rojo server listening:
  Address: localhost
  Port:    34872

Visit http://localhost:34872/ in your browser for more information.

@LPGhatguy
Copy link
Contributor

Hello, thanks for filing an issue!

This is not a Rojo issue, this is a Foreman bug. See Roblox/foreman#45.

You might consider switching to Aftman, which does not have this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants