Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing syncing folders with 'init' in the root #68

Closed
LPGhatguy opened this issue May 9, 2018 · 2 comments
Closed

Allowing syncing folders with 'init' in the root #68

LPGhatguy opened this issue May 9, 2018 · 2 comments

Comments

@LPGhatguy
Copy link
Contributor

This is kind of an extension of #57.

If your partition targets a folder that contains an init.lua or such file, you'll get a stack trace that isn't fun:

16:05:26.890 - Unhandled promise rejection:
16:05:26.891 - 
16:05:26.892 - Plugin_1211549683.Rojo.plugin.Reconciler:185: attempt to call method 'FindFirstChild' (a nil value)
16:05:26.892 - 
16:05:26.893 - Stack Begin
16:05:26.894 - Script 'Plugin_1211549683.Rojo.modules.Promise', Line 81 - field new
16:05:26.894 - Script 'Plugin_1211549683.Rojo.modules.Promise', Line 166 - method andThen
16:05:26.894 - Script 'Plugin_1211549683.Rojo.plugin.Plugin', Line 135 - method _pull
16:05:26.895 - Script 'Plugin_1211549683.Rojo.plugin.Plugin', Line 253
16:05:26.896 - Stack End

This should be supported!

@LPGhatguy LPGhatguy added the type: enhancement Feature or improvement that should potentially happen label May 9, 2018
@LPGhatguy LPGhatguy added this to the 0.4.6 milestone May 9, 2018
@LPGhatguy LPGhatguy modified the milestones: 0.4.6, 0.4.7 May 21, 2018
@LPGhatguy LPGhatguy added feature: idea and removed type: enhancement Feature or improvement that should potentially happen labels May 22, 2018
@LPGhatguy
Copy link
Contributor Author

The more that I think about this, the more I wonder how good of an idea it is.

What happens if you sync that same partition into, say, ReplicatedStorage?

@LPGhatguy LPGhatguy removed this from the 0.4.7 milestone May 22, 2018
@LPGhatguy
Copy link
Contributor Author

This actually does work, the stack trace was because I typo'd a service name, which was fixed in a related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant