You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Whenever a plugin throws a runtime exception, we should add a diagnostic somewhere. Since all diagnostics must be tied to a file, perhaps we tie it to the bsconfig.json?
Currently we only show these in the console as console.error calls.
How do we clear the diagnostics though? Would we need to store them with some type of context? (like the name of the plugin event that crashed, so next time it's okay? Or are they stuck until restart? (That might be fine?).
Should we add an option to disable this functionality, or should it just be on all the time? I vote on all the time.
The text was updated successfully, but these errors were encountered:
Should we add an option to disable this functionality, or should it just be on all the time? I vote on all the time.
I can see two cases where someone might want to keep a plugin that is crashing:
A validation plugin (e.g bslint) that is crashing on one specific line of code that it can't handle for some reason, but works fine for the rest of the codebase. I might not want this to be a blocker for my build
A plugin that transforms files that transforms all files correctly, crashes on one case. It happens that this one case / one file crash is harmless to the build. In this case, perhaps I do not want to disable the plugin (which will break the build) but I do not want to enable the plugin diagnostics because that will also block the build
Whenever a plugin throws a runtime exception, we should add a diagnostic somewhere. Since all diagnostics must be tied to a file, perhaps we tie it to the bsconfig.json?
Currently we only show these in the console as console.error calls.
How do we clear the diagnostics though? Would we need to store them with some type of context? (like the name of the plugin event that crashed, so next time it's okay? Or are they stuck until restart? (That might be fine?).
Should we add an option to disable this functionality, or should it just be on all the time? I vote on all the time.
The text was updated successfully, but these errors were encountered: