Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I would like to add async engine name #1075

Open
saiqulhaq opened this issue Dec 30, 2021 · 1 comment
Open

I would like to add async engine name #1075

saiqulhaq opened this issue Dec 30, 2021 · 1 comment

Comments

@saiqulhaq
Copy link

Hi Rollbar team

My team doesn't know that our Rollbar config uses Sidekiq for reporting, and the Sidekiq was not running on that time
he was wondering why the report is not available on Rollbar
so would you accept my PR if I add any async engine name into the following notifier class?

"[Rollbar] Details: #{uuid_url} (only available if report was successful)"

@waltjones
Copy link
Contributor

@saiqulhaq Sounds like you'd just add the async engine name to the log string, if present? Yes, that would be an acceptable change, assuming the implementation doesn't have side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants