Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from travis-ci #214

Closed
rollbear opened this issue Oct 29, 2020 · 11 comments
Closed

Move away from travis-ci #214

rollbear opened this issue Oct 29, 2020 · 11 comments

Comments

@rollbear
Copy link
Owner

5h40m to complete a run is totally unacceptable, and it's apparently not due to temporary problems, but rather a deliberate decision by travis-ci to give priority to paying customers (can't blame them, but not good for small open source projects like this.)

cirrus-ci, gitub-actions?

Relates o #102.

@arximboldi
Copy link

Sadly, if you pay for Travis, it is still super slow. I am very looking forward to migrate all my projects to something else. Probably Github Actions.

@offa
Copy link
Contributor

offa commented Nov 2, 2020

I'm moving my projects to Github Actions, which is way faster and eg. supports custom container.

@rollbear
Copy link
Owner Author

rollbear commented Dec 28, 2020

Started a setup for github actions on branch try_github_actions. Thu functionality implemented seems to work line, but much is missing.

Remaining issues

  • Code coverage is not collected, and thus not forwarded to coveralls.io
  • Ancient Linux compilers not supported (gcc < 6, clang < 5)
  • No libc++ builds for clang++11
  • libc++ fetch seems flaky. It seems different versions are located in different places.
  • Apple/Clang builds
  • MSVC builds

@offa
Copy link
Contributor

offa commented Dec 28, 2020

Ancient Linux compilers not supported (gcc < 6, clang < 5)

You can use docker images for that. I have migrated another project recently, using the gcc image (down to 4.9) and teeks99/clang-ubuntu (down to 4.0). Unfortunately clang <= 6 needs to build libc++ every time.

No libc++ builds for clang++11

What's the problem with that version? I haven't experienced any issue with that version (using focal base image though).

@offa
Copy link
Contributor

offa commented Dec 28, 2020

  - name: Download Ninja and CMake

Why not stick with the cmake version, provided by the GH Actions images? It's up to date (3.19 at the moment).

Regarding ninja setup: I've used apt-get on linux, but there's a generic build step: https://github.com/seanmiddleditch/gha-setup-ninja

@rollbear
Copy link
Owner Author

Thanks @offa. Will try the docker images. This is work in progress, so the above aren't necessarily problems, just work that is not yet done. I do not foresee problems with Apple/MSVC buids, but I'm not there yet.

Libc++11. The script to download it, proudly stolen (and somewhat modified) from range-v3, fails because it sees clang++ 11.0.1, and there are only RC-images lib libc++ 11.0.1.

@offa
Copy link
Contributor

offa commented Dec 28, 2020

Maybe you can get some ideas from here: https://github.com/Dobiasd/FunctionalPlus/blob/master/.github/workflows/ci.yml

Let me know, if you need some help.

@AndrewPaxie
Copy link
Collaborator

Excited to see this work underway. I'm once more in follow-along mode however.

@rollbear
Copy link
Owner Author

rollbear commented Dec 29, 2020

Coming along nicely. Much less cluttered script now, and covers almost all that is needed. 12 minutes for the full matrix is impressive, but it will (probably) take longer when functionality is added. Still missing a few old clang:s, but those have never caused any problems, so it's not a big deal. Building for more versions of MSVC is a must, since that compiler family has caused so much pain historically.

Remaining todo:

@rollbear
Copy link
Owner Author

Getting there now. coverage collection works, but uploading to coveralls does not. There's an issue for kcov that explains how to do it, though, so it should probably not be long.

SimonKagstrom/kcov#346

@rollbear
Copy link
Owner Author

Finally done. Moved coverage to codecov.io which offered less resistance than coveralls.io. Shiny new badges on the READE too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants