Skip to content

test: add TargetMode related tests for polling watcher #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 1 commit into from
Nov 23, 2025
Merged

test: add TargetMode related tests for polling watcher #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
197 changes: 186 additions & 11 deletions notify/src/poll.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ impl Drop for PollWatcher {
#[cfg(test)]
mod tests {
use super::PollWatcher;
use crate::test::*;
use crate::{Error, ErrorKind, RecursiveMode, TargetMode, WatchMode, Watcher, test::*};

fn watcher() -> (TestWatcher<PollWatcher>, Receiver) {
poll_watcher_channel()
Expand All @@ -700,6 +700,62 @@ mod tests {
rx.wait_ordered_exact([expected(&path).create_any()]);
}

#[test]
#[ignore = "not implemented"]
fn create_self_file() {
let tmpdir = testdir();
let (mut watcher, mut rx) = watcher();

let path = tmpdir.path().join("entry");

watcher.watch_nonrecursively(&path);

std::fs::File::create_new(&path).expect("create");

rx.sleep_until_exists(&path);
rx.wait_ordered_exact([expected(&path).create_any()]);
}

#[test]
#[ignore = "not implemented"]
fn create_self_file_no_track() {
let tmpdir = testdir();
let (mut watcher, _) = watcher();

let path = tmpdir.path().join("entry");

let result = watcher.watcher.watch(
&path,
WatchMode {
recursive_mode: RecursiveMode::NonRecursive,
target_mode: TargetMode::NoTrack,
},
);
assert!(matches!(
result,
Err(Error {
paths: _,
kind: ErrorKind::PathNotFound
})
));
}

#[test]
#[ignore = "TODO: not implemented"]
fn create_self_file_nested() {
let tmpdir = testdir();
let (mut watcher, mut rx) = watcher();

let path = tmpdir.path().join("entry/nested");

watcher.watch_nonrecursively(&path);

std::fs::create_dir_all(path.parent().unwrap()).expect("create");
std::fs::File::create_new(&path).expect("create");

rx.wait_ordered_exact([expected(&path).create_file()]);
}

#[test]
fn create_dir() {
let tmpdir = testdir();
Expand Down Expand Up @@ -731,7 +787,99 @@ mod tests {
}

#[test]
fn remove_file() {
fn rename_file() {
let tmpdir = testdir();
let (mut watcher, mut rx) = watcher();
let path = tmpdir.path().join("entry");
let new_path = tmpdir.path().join("new_entry");
std::fs::File::create_new(&path).expect("Unable to create");

watcher.watch_recursively(&tmpdir);
std::fs::rename(&path, &new_path).expect("Unable to remove");

rx.sleep_while_exists(&path);
rx.sleep_until_exists(&new_path);

rx.wait_unordered_exact([
expected(&path).remove_any(),
expected(&new_path).create_any(),
]);
}

#[test]
#[ignore = "TODO: not implemented"]
fn rename_self_file() {
let tmpdir = testdir();
let (mut watcher, mut rx) = watcher();

let path = tmpdir.path().join("entry");
std::fs::File::create_new(&path).expect("create");

watcher.watch_nonrecursively(&path);
let new_path = tmpdir.path().join("renamed");

std::fs::rename(&path, &new_path).expect("rename");

rx.sleep_while_exists(&path);
rx.sleep_until_exists(&new_path);

rx.wait_unordered_exact([expected(&path).remove_any()])
.ensure_no_tail();

std::fs::rename(&new_path, &path).expect("rename2");

rx.sleep_until_exists(&new_path);
rx.sleep_while_exists(&path);

rx.wait_unordered_exact([expected(&path).create_any()])
.ensure_no_tail();
}

#[test]
#[ignore = "TODO: not implemented"]
fn rename_self_file_no_track() {
let tmpdir = testdir();
let (mut watcher, mut rx) = watcher();

let path = tmpdir.path().join("entry");
std::fs::File::create_new(&path).expect("create");

watcher.watch(
&path,
WatchMode {
recursive_mode: RecursiveMode::NonRecursive,
target_mode: TargetMode::NoTrack,
},
);

let new_path = tmpdir.path().join("renamed");

std::fs::rename(&path, &new_path).expect("rename");

rx.sleep_while_exists(&path);
rx.sleep_until_exists(&new_path);

rx.wait_unordered_exact([expected(&path).remove_any()])
.ensure_no_tail();

let result = watcher.watcher.watch(
&path,
WatchMode {
recursive_mode: RecursiveMode::NonRecursive,
target_mode: TargetMode::NoTrack,
},
);
assert!(matches!(
result,
Err(Error {
paths: _,
kind: ErrorKind::PathNotFound
})
));
}

#[test]
fn delete_file() {
let tmpdir = testdir();
let (mut watcher, mut rx) = watcher();
let path = tmpdir.path().join("entry");
Expand All @@ -745,23 +893,50 @@ mod tests {
}

#[test]
fn rename_file() {
#[ignore = "TODO: not implemented"]
fn delete_self_file() {
let tmpdir = testdir();
let (mut watcher, mut rx) = watcher();
let path = tmpdir.path().join("entry");
let new_path = tmpdir.path().join("new_entry");
std::fs::File::create_new(&path).expect("Unable to create");

watcher.watch_recursively(&tmpdir);
std::fs::rename(&path, &new_path).expect("Unable to remove");
watcher.watch_nonrecursively(&path);

std::fs::remove_file(&path).expect("Unable to remove");

rx.sleep_while_exists(&path);
rx.sleep_until_exists(&new_path);
rx.wait_ordered_exact([expected(&path).remove_any()]);

rx.wait_unordered_exact([
expected(&path).remove_any(),
expected(&new_path).create_any(),
]);
std::fs::write(&path, "").expect("write");

rx.sleep_until_exists(&path);
rx.wait_ordered_exact([expected(&path).create_file()]);
}

#[test]
#[ignore = "TODO: not implemented"]
fn delete_self_file_no_track() {
let tmpdir = testdir();
let (mut watcher, mut rx) = watcher();
let path = tmpdir.path().join("entry");
std::fs::File::create_new(&path).expect("Unable to create");

watcher.watch(
&path,
WatchMode {
recursive_mode: RecursiveMode::NonRecursive,
target_mode: TargetMode::NoTrack,
},
);

std::fs::remove_file(&path).expect("Unable to remove");

rx.sleep_while_exists(&path);
rx.wait_ordered_exact([expected(&path).remove_any()]);

std::fs::write(&path, "").expect("write");

rx.ensure_empty_with_wait();
}

#[test]
Expand Down