Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Creating a game / Team color adding not consistent to editing a game #736

Closed
reflexdd opened this issue Jul 12, 2024 · 6 comments · Fixed by #740
Closed

[BUG] Creating a game / Team color adding not consistent to editing a game #736

reflexdd opened this issue Jul 12, 2024 · 6 comments · Fixed by #740
Assignees
Labels
Milestone

Comments

@reflexdd
Copy link
Contributor

Describe the bug
If you have pre-defined teams with pre-defined colors and would like to create a new game, then the adding a color section is behaving different to the editing a game tab.

To Reproduce

  1. add some colors in the Gamedata/Teams/Edit-Team-Section
team-0
  1. add a new Game in the Gamedata-Section, go to Teams-Tab and select the team with the pre-defined Color
team-1 The pre-defined Colors are not shown
  1. Adding e.g. Black again as color
team-2

leads to an unexpected behaviour
team-3

Expected behavior
When selecting a team the predefined Colors should be shown as when you later edit a Game
team-4

team-5

Version:
2025.beta2

@reflexdd
Copy link
Contributor Author

This doesn't work correctly yet with the pre-defined white and black Teams.

I'v added a new Team Green with pre-defined Color green.
Then add a new Game and go to team Section and select Teams
NT-1

Select Pre-Defined Color

NT-2

and Go back to Other
I'ts not possible to enter now a different color for Black or White Team but for the Green Team it works as expected

NT-3

@frank-weinberg
Copy link
Contributor

Is this with a clean install or with importing from an older beta?
I had to amend the conversion for older json files but that conversion won't run if the file is already marked as v2025.

@reflexdd
Copy link
Contributor Author

This was with a clean download of the dev-Version.

@frank-weinberg
Copy link
Contributor

This must have imported an autosave - the pre-defined teams do not have pre-defined colors.

@reflexdd
Copy link
Contributor Author

reflexdd commented Jul 22, 2024

I downloaded the dev version, edited the Black Team by adding Black as Uniform Color. I then added a new Team Green and added Green as Uniform Color.

No autosave to load from, using builtin defaults only

@frank-weinberg
Copy link
Contributor

Ok, now I can reproduce it. And it's very weird. It does not happen, if you add e.g. "Red" as UC, only if the color matches the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants