Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Entity trainer #473

Closed
Quiddlee opened this issue Aug 31, 2024 · 0 comments Β· Fixed by #492
Closed

FSD: Entity trainer #473

Quiddlee opened this issue Aug 31, 2024 · 0 comments Β· Fixed by #492

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Aug 31, 2024

πŸ“ Describe the refactoring task

Part of the issue #346
Trainer entity refactor

πŸ“ Code location

src/entities/trainer

βœ… Definition of Done (DoD):

  1. create trainer folder in src/entities.
  2. move src/widgets/trainers/ui/trainers-card to src/entities/trainer/ui/trainer-card.
  3. create trainer-card.module.scss file in src/entities/trainer/ui/trainer-card and move all related to trainer-card styles from trainer.scss
  4. refactor trainers.scss file to modules.scss and trainers-card.module.scss as so:
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • rename all classes to be generic e.g .nodejs-trainer πŸ™…β€β™‚οΈ -> .trainer πŸ‘Œ.
  • and everything in your opinion that needs to be refactored
  1. move Trainer type from src/widgets/trainers/trainers.types.ts to src/entities/trainer/types.ts
  2. create index.ts file and re-export Trainer type and TrainerCard component
  3. refactor TrainerCard component to utilize HTML5 tags
  4. Write unit test for TrainerCard component

Example of completing all the steps you can find in src/entities/event/event-card

@Quiddlee Quiddlee added this to RS Site Aug 31, 2024
@Quiddlee Quiddlee moved this to Backlog in RS Site Aug 31, 2024
@thirdmadman thirdmadman self-assigned this Sep 3, 2024
@thirdmadman thirdmadman moved this from Backlog to In Progress in RS Site Sep 4, 2024
@thirdmadman thirdmadman moved this from In Progress to Peer review in RS Site Sep 4, 2024
@thirdmadman thirdmadman moved this from Peer review to Review in RS Site Sep 6, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RS Site Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants