Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget About #489

Closed
Quiddlee opened this issue Sep 3, 2024 · 1 comment Β· Fixed by #576
Closed

FSD: Widget About #489

Quiddlee opened this issue Sep 3, 2024 · 1 comment Β· Fixed by #576

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 3, 2024

πŸ“ Describe the refactoring task

Part of the issue #347
About component refactor

πŸ“ Code location

src/widgets/about/ui/about.tsx

βœ… Definition of Done (DoD):

  1. rename about folder and component to about-course
  2. Refactor about-course.tsx and info-grid.tsx scss to scss modules including:
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • rename all classes to be generic e.g .nodejs-trainer πŸ™…β€β™‚οΈ -> .trainer πŸ‘Œ.
  • and everything in your opinion that needs to be refactored

info-grid.tsx

  1. remove all comments
  2. change all the interfaces to types
  3. refactor JSX to utilize HTML5 tags
  4. remove hasTitle prop completely
  5. get rid of dangerouslySetInnerHTML prop (just pass info as usual - between the tags)
  6. replace h2 with WidgetTitle

about-course.tsx

  1. change all the interfaces to types
  2. move CourseNames to courses-data.types.ts
  3. move about-course.tsx, about-course.module.scss and about-course.test.tsx to src/widgets/about-course/ui/about-course
@ansivgit
Copy link
Collaborator

ansivgit commented Sep 9, 2024

Blocked #375 because subheadings in info-grid should be the Subtitle component

@ansivgit ansivgit added the blocked For task blocked other tasks label Sep 9, 2024
@coderabbitai coderabbitai bot mentioned this issue Sep 11, 2024
8 tasks
@Quiddlee Quiddlee removed the blocked For task blocked other tasks label Sep 13, 2024
@ansivgit ansivgit moved this from Backlog to In Progress in RS Site Sep 24, 2024
@ansivgit ansivgit self-assigned this Sep 24, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RS Site Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants