Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSD: Widget about video #498

Closed
Quiddlee opened this issue Sep 5, 2024 · 0 comments · Fixed by #538
Closed

FSD: Widget about video #498

Quiddlee opened this issue Sep 5, 2024 · 0 comments · Fixed by #538
Assignees
@KristiBo
Labels
high priority refactor
Milestone
🛸 Migration to Fe...

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 5, 2024

📝 Describe the refactoring task

Part of the issue #347
About-video component refactor

📍 Code location

src/widgets/about/ui/about-video.tsx

✅ Definition of Done (DoD):

  1. Refactor about-video.tsx scss to scss modules including:
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • rename all classes to be generic e.g .nodejs-trainer 🙅‍♂️ -> .trainer 👌.
  • and everything in your opinion that needs to be refactored
  1. refactor JSX to utilize HTML5 tags
  2. move unit test inside the ui folder
  3. update unit test if needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristiBo KristiBo

Labels
high priority refactor
Projects
RS Site
Status: Done
Milestone
🛸 Migration to Feature Sliced Design ...
Development

Successfully merging a pull request may close this issue.

498-refactor: Widget about video rolling-scopes/site
2 participants
@KristiBo @Quiddlee