Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSD: Widget Course main #532

Closed
7 tasks done
Quiddlee opened this issue Sep 17, 2024 · 0 comments · Fixed by #543
Closed
7 tasks done

FSD: Widget Course main #532

Quiddlee opened this issue Sep 17, 2024 · 0 comments · Fixed by #543
Assignees
@SkarabeyDM @ansivgit
Labels
good first issue Good for newcomers high priority refactor
Milestone
🛸 Migration to Fe...

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 17, 2024 •
edited by SkarabeyDM
Loading

📝 Describe the refactoring task

Part of the issue #347

📍 Code location

src/widgets/course-main

✅ Definition of Done (DoD):

course-main.tsx

  • move course-main.test.tsx, course-main.tsx, course-main.module.scss to ui folder
  • replace interface with type
  • change JSX classes declaration to use cx (example in entities folder components)
  • rename utils folder to helpers
  • move courseLoader to entities/course/api.
  • rename courseLoader -> loader including file name
  • re-export loader in the entities/course/index.ts file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SkarabeyDM SkarabeyDM

@ansivgit ansivgit

Labels
good first issue Good for newcomers high priority refactor
Projects
RS Site
Status: Done
Milestone
🛸 Migration to Feature Sliced Design ...
Development

Successfully merging a pull request may close this issue.

532-refactor: FSD: Widget Course main rolling-scopes/site
3 participants
@SkarabeyDM @ansivgit @Quiddlee