Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget MentorsWanted #550

Closed
Quiddlee opened this issue Sep 25, 2024 · 0 comments Β· Fixed by #599
Closed

FSD: Widget MentorsWanted #550

Quiddlee opened this issue Sep 25, 2024 · 0 comments Β· Fixed by #599

Comments

@Quiddlee
Copy link
Member

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/mentors-wanted

βœ… Definition of Done (DoD):

  1. Refactor mentors-wanted.tsx's scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

mentors-wanted.tsx

  1. create unit test for mentors-wanted component inside the ui folder
  2. encapsulate the https://github.com/rolling-scopes-school/tasks/tree/master/angular/mentoring link in src/app/const/index.ts -> LINKS constant
@Quiddlee Quiddlee moved this to Backlog in RS Site Sep 25, 2024
@Quiddlee Quiddlee added this to RS Site Sep 25, 2024
@Quiddlee Quiddlee added the good first issue Good for newcomers label Sep 25, 2024
@KristiBo KristiBo self-assigned this Sep 30, 2024
@KristiBo KristiBo moved this from In Progress to Peer review in RS Site Oct 9, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RS Site Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants