Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Required #561

Open
Quiddlee opened this issue Sep 26, 2024 · 0 comments Β· May be fixed by #682
Open

FSD: Widget Required #561

Quiddlee opened this issue Sep 26, 2024 · 0 comments Β· May be fixed by #682

Comments

@Quiddlee
Copy link
Member

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/required

βœ… Definition of Done (DoD):

required.module.scss

  1. Refactor required.tsx's scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

required.tsx

  1. replace div's with HTML5 tags
  2. replace interface with type
  3. get rid of ternary operator inside return

required.test.tsx

  1. move test file to ui folder
  2. remove all comments

types.ts

  1. rename required.types.ts to types.ts
  2. move LinkList to shared/types.ts
@Quiddlee Quiddlee moved this to Backlog in RS Site Sep 26, 2024
@Quiddlee Quiddlee added this to RS Site Sep 26, 2024
@thirdmadman thirdmadman self-assigned this Sep 29, 2024
@thirdmadman thirdmadman moved this from Backlog to In Progress in RS Site Sep 29, 2024
@Quiddlee Quiddlee assigned Quiddlee and unassigned thirdmadman Dec 2, 2024
@Quiddlee Quiddlee linked a pull request Dec 7, 2024 that will close this issue
8 tasks
@Quiddlee Quiddlee moved this from In Progress to Peer review in RS Site Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Peer review
Development

Successfully merging a pull request may close this issue.

2 participants