Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Speakers #564

Closed
Quiddlee opened this issue Sep 27, 2024 · 0 comments Β· Fixed by #668
Closed

FSD: Widget Speakers #564

Quiddlee opened this issue Sep 27, 2024 · 0 comments Β· Fixed by #668

Comments

@Quiddlee
Copy link
Member

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/speakers

βœ… Definition of Done (DoD):

speakers.module.scss

  1. Refactor speakers.tsx's scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

speakers.tsx

  1. replace div's with HTML5 tags
  2. rename image to something more meaningfull.
  3. add descriptive alt attribute
  4. encapsulate rolling.scopes@gmail.com email inside shared constant
  5. replace EmailIcon with plain Image component

speakers.test.tsx

  1. move test file to ui folder
@Quiddlee Quiddlee moved this to Backlog in RS Site Sep 27, 2024
@Quiddlee Quiddlee added this to RS Site Sep 27, 2024
@Quiddlee Quiddlee self-assigned this Nov 24, 2024
@Quiddlee Quiddlee moved this from In Progress to Peer review in RS Site Nov 29, 2024
@Quiddlee Quiddlee moved this from Peer review to Review in RS Site Dec 7, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RS Site Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant