feat(babel): allow excluding manual chunks when transforming generated code (#1906)

* feat(babel): add includeChunks/excludeChunks to filter generated-code transforms by manual chunk name; docs + tests

* chore(babel): fix lint in as-output-plugin test (avoid explicit undefined; disable consistent-return for manualChunks)

* ci(workflows): avoid 'git pull' divergence error; use explicit fetch refspecs and default_branch; update Windows to windows-latest

* chore(babel): remove superfluous "new:" inline comment in options destructure

---------

Co-authored-by: CharlieHelps <charlie@charlielabs.ai>

Author: charliecreates[bot]

.github/workflows/node-windows.yml

@@ -13,7 +13,7 @@ on:
 
 jobs:
   build:
-    runs-on: windows-2019
+    runs-on: windows-latest
 
     strategy:
       matrix:
@@ -30,7 +30,15 @@ jobs:
           fetch-depth: 2
 
       - name: Update Master
-        run: git pull --force --no-tags origin master:master
+        shell: bash
+        run: |
+          # Ensure the remote-tracking ref exists and is up-to-date without invoking an implicit merge
+           set -euo pipefail
+          # Ensure the remote-tracking ref and local branch ref are up-to-date without invoking an implicit merge
+          DEFAULT_BRANCH="${{ github.event.repository.default_branch }}"
+          git fetch --no-tags --force origin \
+            "+refs/heads/${DEFAULT_BRANCH}:refs/remotes/origin/${DEFAULT_BRANCH}" \
+            "+refs/heads/${DEFAULT_BRANCH}:refs/heads/${DEFAULT_BRANCH}"
 
       - name: Setup Node
         uses: actions/setup-node@v3

.github/workflows/release.yml

@@ -25,8 +25,11 @@ jobs:
 
       - name: Update Master
         run: |
-          git pull --force --no-tags origin master:master
-          git checkout master
+          set -euo pipefail
+          DEFAULT_BRANCH="${{ github.event.repository.default_branch }}"
+          # Avoid implicit merges; update the remote-tracking ref explicitly
+          git fetch --no-tags --force origin "+refs/heads/${DEFAULT_BRANCH}:refs/remotes/origin/${DEFAULT_BRANCH}"
+          git checkout "${DEFAULT_BRANCH}"
           git fetch --tags
 
       - name: Setup Node
@@ -86,10 +89,12 @@ jobs:
 
       - name: Push Release and Cleanup
         run: |
+          set -euo pipefail
+          DEFAULT_BRANCH="${{ github.event.repository.default_branch }}"
           pnpm lint:docs
           git checkout .npmrc
           git add . && git commit --amend --no-edit
-          git pull origin master --no-edit
+          git pull origin "${DEFAULT_BRANCH}" --no-edit
           git rebase
-          git push origin HEAD:master
-          git push origin HEAD:master --tags
+          git push origin HEAD:"${DEFAULT_BRANCH}"
+          git push origin HEAD:"${DEFAULT_BRANCH}" --tags

.github/workflows/validate.yml

@@ -28,7 +28,14 @@ jobs:
           fetch-depth: 2
 
       - name: Update Master
-        run: git pull --force --no-tags origin master:master
+        run: |
+          # Ensure the remote-tracking ref exists and is up-to-date without invoking an implicit merge
+           set -euo pipefail
+          # Ensure the remote-tracking ref and local branch ref are up-to-date without invoking an implicit merge
+          DEFAULT_BRANCH="${{ github.event.repository.default_branch }}"
+          git fetch --no-tags --force origin \
+            "+refs/heads/${DEFAULT_BRANCH}:refs/remotes/origin/${DEFAULT_BRANCH}" \
+            "+refs/heads/${DEFAULT_BRANCH}:refs/heads/${DEFAULT_BRANCH}"
 
       - name: Setup Node
         uses: actions/setup-node@v3

packages/babel/README.md

@@ -200,6 +200,30 @@ export default {
 
 The `include`, `exclude` and `extensions` options are ignored when using `getBabelOutputPlugin` and `createBabelOutputPluginFactory` will produce warnings, and there are a few more points to note that users should be aware of.
 
+When transforming generated code, you can instead control which chunks are processed by matching their manual chunk names via the `includeChunks`/`excludeChunks` options. These patterns are matched against `chunk.name` as provided to Rollup's `renderChunk` hook and are especially useful to skip already-transpiled/minified vendor chunks:
+
+```js
+// rollup.config.js
+import { getBabelOutputPlugin } from '@rollup/plugin-babel';
+
+export default {
+  input: 'main.js',
+  manualChunks(id) {
+    if (id.includes('big-library')) return 'vendor';
+  },
+  output: {
+    format: 'es',
+    plugins: [
+      getBabelOutputPlugin({
+        presets: ['@babel/preset-env'],
+        // Do not transform the 'vendor' manual chunk
+        excludeChunks: ['vendor']
+      })
+    ]
+  }
+};
+```
+
 You can also run the plugin twice on the code, once when processing the input files to transpile special syntax to JavaScript and once on the output to transpile to a lower compatibility target:
 
 ```js

packages/babel/src/index.js

@@ -209,6 +209,9 @@ function createBabelOutputPluginFactory(customCallback = returnObject) {
       overrides
     );
 
+    // cache for chunk name filter (includeChunks/excludeChunks)
+    let chunkNameFilter;
+
     return {
       name: 'babel',
 
@@ -234,6 +237,8 @@ function createBabelOutputPluginFactory(customCallback = returnObject) {
         /* eslint-disable no-unused-vars */
         const {
           allowAllFormats,
+          includeChunks,
+          excludeChunks,
           exclude,
           extensions,
           externalHelpers,
@@ -243,6 +248,16 @@ function createBabelOutputPluginFactory(customCallback = returnObject) {
           ...babelOptions
         } = unpackOutputPluginOptions(pluginOptionsWithOverrides, outputOptions);
         /* eslint-enable no-unused-vars */
+        // If includeChunks/excludeChunks are specified, filter by chunk.name
+        if (includeChunks != null || excludeChunks != null) {
+          if (!chunkNameFilter) {
+            chunkNameFilter = createFilter(includeChunks, excludeChunks, { resolve: false });
+          }
+          if (!chunkNameFilter(chunk.name)) {
+            // Skip transforming this chunk
+            return null;
+          }
+        }
 
         return transformCode(code, babelOptions, overrides, customOptions, this);
       }

packages/babel/test/as-output-plugin.mjs

@@ -378,3 +378,34 @@ console.log(\`the answer is \${answer}\`);
 `
   );
 });
+
+test('allows excluding manual chunks from output transform via `excludeChunks`', async (t) => {
+  const bundle = await rollup({
+    input: `${FIXTURES}chunks/main.js`
+  });
+
+  const output = await getCode(
+    bundle,
+    {
+      format: 'es',
+      // eslint-disable-next-line consistent-return
+      manualChunks(id) {
+        // Place the dependency into a named manual chunk
+        if (id.endsWith(`${nodePath.sep}chunks${nodePath.sep}dep.js`)) return 'vendor';
+      },
+      plugins: [
+        getBabelOutputPlugin({
+          // Transform generated code but skip the 'vendor' manual chunk
+          presets: ['@babel/env'],
+          excludeChunks: ['vendor']
+        })
+      ]
+    },
+    true
+  );
+
+  const codes = output.map(({ code }) => code);
+  // The vendor chunk should remain untransformed and contain the arrow function as-is
+  // Debug output intentionally omitted
+  t.true(codes.some((c) => c.includes('=> 42')));
+});

packages/babel/types/index.d.ts

@@ -48,6 +48,16 @@ export interface RollupBabelOutputPluginOptions
    * @default false
    */
   allowAllFormats?: boolean;
+  /**
+   * Limit transforming of generated code to specific manual chunks by name.
+   * These patterns are matched against the `chunk.name` value in Rollup's `renderChunk` hook.
+   */
+  includeChunks?: FilterPattern;
+  /**
+   * Exclude specific manual chunks by name from transforming the generated code.
+   * These patterns are matched against the `chunk.name` value in Rollup's `renderChunk` hook.
+   */
+  excludeChunks?: FilterPattern;
 }
 
 export type RollupBabelCustomInputPluginOptions = (